Backport semi-sync fixes #69
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actions (vitessio#13075) * Fix convertBoolToSemiSyncAction method to account for all semi sync actions Signed-off-by: William Lu <william.lu@shopify.com> Signed-off-by: William Lu <william@tamedfox.ca>
arthurschreiber
force-pushed
the
arthur/backport-semi-sync-fixes
branch
from
2059066
to
1d32795
Compare
|
This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:
If no action is taken within 7 days, this PR will be closed. |
|
This was backported to v15 and will be picked up once we upgrade to the latest v15 changes from upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This backports the semi-sync fix from vitessio#13075 for use in our fork (which is still at v15).
I got the go-ahead from the Vitess maintainers to perform backports to v15 and v16, but I feel like we should test this on
vitesstbefore I open PRs upstream to backport this.